Update spec tests to [email protected] #11952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sudeepdino008
commented
Sep 11, 2024
•
sudeepdino008
commented
- additionally, some changes were made lately to 7702 - https://eips.ethereum.org/EIPS/eip-7702 (specially auth empty list; signatures; contract creation with 7702). The PR incorporates those.
sudeepdino008
commented
Sep 11, 2024
turbo/stages/mock/mock_sentry.go
Outdated
| return err | ||
| } | ||
| } | ||
| // for i := n; i < chain.Length(); i++ { |
There was a problem hiding this comment.
I've commented these out; in order for the execution to flow into el InsertBlocks functionalities, where things like empty auth list or invalid auth sigs can be checked. For tests not-expecting-to-fail, the el should still check all the stuff in HashCheck() after block execution, and float up errors if any.
There was a problem hiding this comment.
but this messes up block_test.go#wrongtransactionsTrie.json which relies on HashCheck being executed. I'm adding it back
somnathb1
approved these changes
Sep 12, 2024
somnathb1
added a commit
that referenced
this pull request
Sep 12, 2024
- additionally, some changes were made lately to 7702 - https://eips.ethereum.org/EIPS/eip-7702 (specially auth empty list; signatures; contract creation with 7702). The PR incorporates those. --------- Co-authored-by: Somnath <[email protected]>
yperbasis
pushed a commit
that referenced
this pull request
Oct 3, 2024
- additionally, some changes were made lately to 7702 - https://eips.ethereum.org/EIPS/eip-7702 (specially auth empty list; signatures; contract creation with 7702). The PR incorporates those. --------- Co-authored-by: Somnath <[email protected]>
yperbasis
added a commit
that referenced
this pull request
Oct 3, 2024
Cherry pick #11952 Co-authored-by: sudeep <[email protected]> Co-authored-by: Somnath <[email protected]>
AskAlexSharov
pushed a commit
that referenced
this pull request
Oct 21, 2024
Cherry pick #11952 Co-authored-by: sudeep <[email protected]> Co-authored-by: Somnath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.